Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add variables in calendar.eventIsRunning condition in scene #1450

Merged
merged 4 commits into from Mar 4, 2022
Merged

Add variables in calendar.eventIsRunning condition in scene #1450

merged 4 commits into from Mar 4, 2022

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Mar 4, 2022 •
edited

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@relativeci
Copy link

relativeci bot commented Mar 4, 2022 •
edited

Job #215: Bundle Size — 6.73MB (+0.03%).

b6f913b vs b58c3d4

Changed metrics (2/8)
Metric Current Baseline
Initial JS 2.92MB(+0.07%) 2.91MB
Cache Invalidation 46.22% 43.16%
Changed assets by type (1/7)
            Current     Baseline
JS 4.82MB (+0.04%) 4.82MB

View Job #215 report on app.relative-ci.com

@codecov
Copy link

codecov bot commented Mar 4, 2022 •
edited

Codecov Report

Merging #1450 (a6df85a) into master (b58c3d4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1450   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files         615      615           
  Lines        8840     8844    +4     
=======================================
+ Hits         8537     8541    +4     
  Misses        303      303
Impacted Files Coverage Δ
server/lib/scene/scene.checkCalendarTriggers.js 100.00% <ø> (ø)
server/lib/scene/scene.actions.js 97.88% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b58c3d4...a6df85a. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit b6f913b into master Mar 4, 2022
@Pierre-Gilles Pierre-Gilles deleted the add-variable-to-calendar-condition branch March 4, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Pierre-Gilles